Centroid Community CNC Support Forum

cncsnw wrote: ↑Tue Jul 01, 2025 1:15 pm A couple of style and convention comments:

Code: Select all

; Check if Tool Setter Machine Ready (INP14) is active
; This sets ToolSetterReady_M if INP14 is active, otherwise, it will be RST by default below
IF TRUE THEN RST ToolSetterReady_M ; Default to OFF
IF INP14 THEN SET ToolSetterReady_M

Supposing that you have previously named INP14 as "ProbeArmMachineReady", it would be better to use that assigned name rather than the raw input name.

The above code (but using an assigned name) is exactly the same as:

Code: Select all

IF ProbeArmMachineReady THEN (ToolSetterReady_M)

... except that this version takes one line instead of two, probably runs a little faster, and is less prone to editing errors.

If there is no other condition that sets or resets ToolSetterReady_M, then you could just as well leave it out and reference ProbeArmMachineReady directly instead. The only reason to copy an input to a memory bit is so that M function macros and the cncxmsg.txt file can refer to a memory bit address (#70xxx / MEMxxx) which does not change even if the sensor gets moved to a different PLC input.

Regarding error reporting: fault conditions are not the same as error conditions.
See http://www.cncsnw.com/PLCApplicationsMPU11.htm

Code: Select all

IF SV_PROGRAM_RUNNING && !ToolSetterReady_M && !SV_DOING_AUTO_TOOL_MEASURE
THEN ErrorMsg_W = TOOLSETTER_NOT_READY_MSG,
SET ErrorFlag_M,
SET SV_STOP

Since you apparently intend this to be an error condition (one that stops the program cycle but does not remove power from the servos), you should not set SV_STOP.

If you wanted it to be a fault, you would assign the message code to FaultMsg_W instead of ErrorMsg_W, and you would not set ErrorFlag_M. Also, it would be better to set "OtherFault_M" rather than setting SV_STOP directly, so that the fault-detect and fault-reset code in MainStage can work properly.

I am curious why it is better to set OtherFault_M rather than set SV_Stop directly?

Code: Select all

; Control ToolSetterArmDown (OUT19) with Aux3Key_M (push and hold)
; At the start of every check ensure ToolSetterArmDown is deactivated and reset.
IF TRUE THEN RST ToolSetterArmDown
IF TRUE THEN RST ToolSetterArmDownActive_M
IF TRUE THEN RST Aux3LED

; Make sure up and down can't be active at the same time.
IF Aux3Key_M && !ToolSetterArmUpActive_M
THEN SET ToolSetterArmDown, SET ToolSetterArmDownActive_M, SET Aux3LED

; Control ToolSetterArmUp (OUT20) with Aux4Key_M (push and hold)
; At the start of every check ensure ToolSetterArmUp is deactivated and reset.
IF TRUE THEN RST ToolSetterArmUp
IF TRUE THEN RST ToolSetterArmUpActive_M
IF TRUE THEN RST Aux4LED

; Make sure up and down can't be active at the same time.
IF Aux4Key_M && !ToolSetterArmDownActive_M
THEN SET ToolSetterArmUp, SET ToolSetterArmUpActive_M, SET Aux4LED

; Control ToolSetterArmDown with Aux3 (push and hold)
IF Aux3Key_M && !(SV_STOP || Aux4Key_M)
  THEN (ToolSetterArmDown),
       (Aux3LED)

; Control ToolSetterArmUp with Aux4 (push and hold)
IF Aux4Key_M && !(SV_STOP || Aux3Key_M)
  THEN (ToolSetterArmUp),
       (Aux4LED)